Clamp calculated sourcemap positions rather than throwing #28583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he underlying file to drift out of date with the sourcemap without a crash
sheetalkamat
approved these changes
Nov 16, 2018
sheetalkamat
added a commit
that referenced
this pull request
Dec 3, 2018
sheetalkamat
added a commit
that referenced
this pull request
Dec 6, 2018
sheetalkamat
added a commit
that referenced
this pull request
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow the underlying file to drift out of date with the sourcemap without a crash. (This means declaration maps get more inaccurate the longer it's been since the sourcemap was updated)
As the
TODOmentions, in an ideal world, I think we track edits to the sourcemapped file between when the sourcemap was generated and when we request positions in that file, and apply those edits to the linemap we generate for the mappings and the positions we generate from it; but I don't think we have much in place to do that efficiently right now (since it would require monitoring a file we otherwise wouldn't be looking at).Fixes #25844