Skip to content

Minor cleanups in checkUnusedIdentifiers #28513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 17, 2018
Merged

Minor cleanups in checkUnusedIdentifiers #28513

1 commit merged into from
Nov 17, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 14, 2018

  • Instead of checking for ambient nodes after taking them out of potentiallyUnusedIdentifiers, never add them there in the first place.
  • The cases for ImportType and others are disjoint, so give that its own function instead of checkUnusedTypeParameters.
  • Interface case is identical to other cases, so share code.

@ghost ghost assigned sheetalkamat Nov 17, 2018
@ghost ghost requested a review from sheetalkamat November 17, 2018 00:20
@ghost ghost merged commit da33c58 into master Nov 17, 2018
@ghost ghost deleted the checkUnusedIdentifiers branch November 17, 2018 00:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sheetalkamat sheetalkamat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheetalkamat