Skip to content

Only bind module.exports if no local definition exists #25869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2018
Merged

Only bind module.exports if no local definition exists #25869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
830f8af
Only bind module.exports if no local definition exists
sandersn Jul 23, 2018
1b43684
Only type module.exports inside module files
sandersn Jul 24, 2018
8de9ba3
Merge branch 'master' into js/only-bind-module-exports-if-no-local-de…
sandersn Jul 24, 2018
67438dc
Only bind module.exports in a commonjs module
sandersn Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,7 +2072,10 @@ namespace ts {
if (isSpecialPropertyDeclaration(node as PropertyAccessExpression)) {
bindSpecialPropertyDeclaration(node as PropertyAccessExpression);
}
if (isInJavaScriptFile(node) && isModuleExportsPropertyAccessExpression(node as PropertyAccessExpression)) {
if (isInJavaScriptFile(node) &&
file.commonJsModuleIndicator &&
isModuleExportsPropertyAccessExpression(node as PropertyAccessExpression) &&
!lookupSymbolForNameWorker(container, "module" as __String)) {
declareSymbol(container.locals!, /*parent*/ undefined, (node as PropertyAccessExpression).expression as Identifier,
SymbolFlags.FunctionScopedVariable | SymbolFlags.ModuleExports, SymbolFlags.FunctionScopedVariableExcludes);
}
Expand Down
12 changes: 12 additions & 0 deletions tests/baselines/reference/conflictingCommonJSES2015Exports.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
tests/cases/conformance/salsa/bug24934.js(2,1): error TS2304: Cannot find name 'module'.


==== tests/cases/conformance/salsa/bug24934.js (1 errors) ====
export function abc(a, b, c) { return 5; }
module.exports = { abc };
~~~~~~
!!! error TS2304: Cannot find name 'module'.
==== tests/cases/conformance/salsa/use.js (0 errors) ====
import { abc } from './bug24934';
abc(1, 2, 3);

3 changes: 0 additions & 3 deletions tests/baselines/reference/conflictingCommonJSES2015Exports.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ export function abc(a, b, c) { return 5; }
>c : Symbol(c, Decl(bug24934.js, 0, 25))

module.exports = { abc };
>module.exports : Symbol("tests/cases/conformance/salsa/bug24934", Decl(bug24934.js, 0, 0))
>module : Symbol(module, Decl(bug24934.js, 0, 42))
>exports : Symbol("tests/cases/conformance/salsa/bug24934", Decl(bug24934.js, 0, 0))
>abc : Symbol(abc, Decl(bug24934.js, 1, 18))

=== tests/cases/conformance/salsa/use.js ===
Expand Down
8 changes: 4 additions & 4 deletions tests/baselines/reference/conflictingCommonJSES2015Exports.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ export function abc(a, b, c) { return 5; }
>5 : 5

module.exports = { abc };
>module.exports = { abc } : typeof import("tests/cases/conformance/salsa/bug24934")
>module.exports : typeof import("tests/cases/conformance/salsa/bug24934")
>module : { "tests/cases/conformance/salsa/bug24934": typeof import("tests/cases/conformance/salsa/bug24934"); }
>exports : typeof import("tests/cases/conformance/salsa/bug24934")
>module.exports = { abc } : any
>module.exports : any
>module : any
>exports : any
>{ abc } : { abc: (a: any, b: any, c: any) => number; }
>abc : (a: any, b: any, c: any) => number

Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/contextualTypedSpecialAssignment.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ exports.x
module.exports.y = {
>module.exports.y : Symbol(y, Decl(test.js, 45, 9))
>module.exports : Symbol(y, Decl(test.js, 45, 9))
>module : Symbol(module, Decl(test.js, 45, 9), Decl(test.js, 51, 1))
>module : Symbol(module, Decl(test.js, 45, 9))
>exports : Symbol("tests/cases/conformance/salsa/test", Decl(test.js, 0, 0))
>y : Symbol(y, Decl(test.js, 45, 9))

Expand All @@ -116,7 +116,7 @@ module.exports.y = {
module.exports.y
>module.exports.y : Symbol(y, Decl(test.js, 45, 9))
>module.exports : Symbol("tests/cases/conformance/salsa/test", Decl(test.js, 0, 0))
>module : Symbol(module, Decl(test.js, 45, 9), Decl(test.js, 51, 1))
>module : Symbol(module, Decl(test.js, 45, 9))
>exports : Symbol("tests/cases/conformance/salsa/test", Decl(test.js, 0, 0))
>y : Symbol(y, Decl(test.js, 45, 9))

Expand Down
4 changes: 2 additions & 2 deletions tests/baselines/reference/jsdocTypeFromChainedAssignment2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ exports.f = exports.g = function fg(n) {
module.exports.h = module.exports.i = function hi(mom) {
>module.exports.h : Symbol(h, Decl(mod.js, 3, 1))
>module.exports : Symbol(h, Decl(mod.js, 3, 1))
>module : Symbol(module, Decl(mod.js, 3, 1), Decl(mod.js, 5, 18))
>module : Symbol(module, Decl(mod.js, 3, 1))
>exports : Symbol("tests/cases/conformance/jsdoc/mod", Decl(mod.js, 0, 0))
>h : Symbol(h, Decl(mod.js, 3, 1))
>module.exports.i : Symbol(i, Decl(mod.js, 5, 18))
>module.exports : Symbol(i, Decl(mod.js, 5, 18))
>module : Symbol(module, Decl(mod.js, 3, 1), Decl(mod.js, 5, 18))
>module : Symbol(module, Decl(mod.js, 3, 1))
>exports : Symbol("tests/cases/conformance/jsdoc/mod", Decl(mod.js, 0, 0))
>i : Symbol(i, Decl(mod.js, 5, 18))
>hi : Symbol(hi, Decl(mod.js, 5, 37))
Expand Down
38 changes: 19 additions & 19 deletions tests/baselines/reference/moduleExportAlias.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ exports.func2 = function () { };
var moduleExportsAlias = module.exports;
>moduleExportsAlias : Symbol(moduleExportsAlias, Decl(b.js, 4, 3))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

moduleExportsAlias.func3 = function () { };
Expand All @@ -132,15 +132,15 @@ moduleExportsAlias.func3 = function () { };
module.exports.func4 = function () { };
>module.exports.func4 : Symbol(func4, Decl(b.js, 5, 43))
>module.exports : Symbol(func4, Decl(b.js, 5, 43))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func4 : Symbol(func4, Decl(b.js, 5, 43))

var multipleDeclarationAlias1 = exports = module.exports;
>multipleDeclarationAlias1 : Symbol(multipleDeclarationAlias1, Decl(b.js, 8, 3))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

multipleDeclarationAlias1.func5 = function () { };
Expand All @@ -151,7 +151,7 @@ multipleDeclarationAlias1.func5 = function () { };
var multipleDeclarationAlias2 = module.exports = exports;
>multipleDeclarationAlias2 : Symbol(multipleDeclarationAlias2, Decl(b.js, 11, 3))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

Expand All @@ -177,7 +177,7 @@ var multipleDeclarationAlias4 = someOtherVariable = module.exports;
>multipleDeclarationAlias4 : Symbol(multipleDeclarationAlias4, Decl(b.js, 18, 3))
>someOtherVariable : Symbol(someOtherVariable, Decl(b.js, 14, 3))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

multipleDeclarationAlias4.func8 = function () { };
Expand All @@ -188,7 +188,7 @@ multipleDeclarationAlias4.func8 = function () { };
var multipleDeclarationAlias5 = module.exports = exports = {};
>multipleDeclarationAlias5 : Symbol(multipleDeclarationAlias5, Decl(b.js, 21, 3))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

Expand All @@ -201,7 +201,7 @@ var multipleDeclarationAlias6 = exports = module.exports = {};
>multipleDeclarationAlias6 : Symbol(multipleDeclarationAlias6, Decl(b.js, 24, 3))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

multipleDeclarationAlias6.func10 = function () { };
Expand All @@ -212,7 +212,7 @@ multipleDeclarationAlias6.func10 = function () { };
exports = module.exports = someOtherVariable = {};
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>someOtherVariable : Symbol(someOtherVariable, Decl(b.js, 14, 3))

Expand All @@ -224,14 +224,14 @@ exports.func11 = function () { };
module.exports.func12 = function () { };
>module.exports.func12 : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))
>module.exports : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func12 : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))

exports = module.exports = someOtherVariable = {};
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>someOtherVariable : Symbol(someOtherVariable, Decl(b.js, 14, 3))

Expand All @@ -243,14 +243,14 @@ exports.func11 = function () { };
module.exports.func12 = function () { };
>module.exports.func12 : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))
>module.exports : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func12 : Symbol(func12, Decl(b.js, 28, 33), Decl(b.js, 32, 33))

exports = module.exports = {};
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

exports.func13 = function () { };
Expand All @@ -261,14 +261,14 @@ exports.func13 = function () { };
module.exports.func14 = function () { };
>module.exports.func14 : Symbol(func14, Decl(b.js, 36, 33))
>module.exports : Symbol(func14, Decl(b.js, 36, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func14 : Symbol(func14, Decl(b.js, 36, 33))

exports = module.exports = {};
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

exports.func15 = function () { };
Expand All @@ -279,13 +279,13 @@ exports.func15 = function () { };
module.exports.func16 = function () { };
>module.exports.func16 : Symbol(func16, Decl(b.js, 40, 33))
>module.exports : Symbol(func16, Decl(b.js, 40, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func16 : Symbol(func16, Decl(b.js, 40, 33))

module.exports = exports = {};
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

Expand All @@ -297,13 +297,13 @@ exports.func17 = function () { };
module.exports.func18 = function () { };
>module.exports.func18 : Symbol(func18, Decl(b.js, 44, 33))
>module.exports : Symbol(func18, Decl(b.js, 44, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func18 : Symbol(func18, Decl(b.js, 44, 33))

module.exports = {};
>module.exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))

exports.func19 = function () { };
Expand All @@ -314,7 +314,7 @@ exports.func19 = function () { };
module.exports.func20 = function () { };
>module.exports.func20 : Symbol(func20, Decl(b.js, 48, 33))
>module.exports : Symbol(func20, Decl(b.js, 48, 33))
>module : Symbol(module, Decl(b.js, 4, 24), Decl(b.js, 5, 43), Decl(b.js, 8, 41), Decl(b.js, 11, 31), Decl(b.js, 18, 51) ... and 14 more)
>module : Symbol(module, Decl(b.js, 4, 24))
>exports : Symbol("tests/cases/conformance/salsa/b", Decl(b.js, 0, 0))
>func20 : Symbol(func20, Decl(b.js, 48, 33))

Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/moduleExportAlias4.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = class C {}
module.exports.D = class D { }
>module.exports.D : Symbol(D)
>module.exports : Symbol(D, Decl(bug24024.js, 2, 27))
>module : Symbol(module, Decl(bug24024.js, 1, 31), Decl(bug24024.js, 2, 27))
>module : Symbol(module, Decl(bug24024.js, 1, 31))
>exports : Symbol("tests/cases/conformance/salsa/bug24024", Decl(bug24024.js, 0, 0))
>D : Symbol(D, Decl(bug24024.js, 2, 27))
>D : Symbol(D, Decl(bug24024.js, 3, 18))
Expand Down
6 changes: 3 additions & 3 deletions tests/baselines/reference/moduleExportAssignment.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ npmlog.on('hi') // both references should see EE.on
module.exports.on('hi') // here too
>module.exports.on : Symbol(EE.on, Decl(npmlog.js, 0, 10))
>module.exports : Symbol("tests/cases/conformance/salsa/npmlog", Decl(npmlog.js, 0, 0))
>module : Symbol(module, Decl(npmlog.js, 4, 12), Decl(npmlog.js, 6, 15), Decl(npmlog.js, 9, 12), Decl(npmlog.js, 11, 8))
>module : Symbol(module, Decl(npmlog.js, 4, 12))
>exports : Symbol("tests/cases/conformance/salsa/npmlog", Decl(npmlog.js, 0, 0))
>on : Symbol(EE.on, Decl(npmlog.js, 0, 10))

Expand All @@ -50,7 +50,7 @@ npmlog.x = 1
module.exports.y = 2
>module.exports.y : Symbol(y, Decl(npmlog.js, 9, 12))
>module.exports : Symbol(y, Decl(npmlog.js, 9, 12))
>module : Symbol(module, Decl(npmlog.js, 4, 12), Decl(npmlog.js, 6, 15), Decl(npmlog.js, 9, 12), Decl(npmlog.js, 11, 8))
>module : Symbol(module, Decl(npmlog.js, 4, 12))
>exports : Symbol("tests/cases/conformance/salsa/npmlog", Decl(npmlog.js, 0, 0))
>y : Symbol(y, Decl(npmlog.js, 9, 12))

Expand All @@ -62,7 +62,7 @@ npmlog.y
module.exports.x
>module.exports.x : Symbol(x, Decl(npmlog.js, 7, 23))
>module.exports : Symbol("tests/cases/conformance/salsa/npmlog", Decl(npmlog.js, 0, 0))
>module : Symbol(module, Decl(npmlog.js, 4, 12), Decl(npmlog.js, 6, 15), Decl(npmlog.js, 9, 12), Decl(npmlog.js, 11, 8))
>module : Symbol(module, Decl(npmlog.js, 4, 12))
>exports : Symbol("tests/cases/conformance/salsa/npmlog", Decl(npmlog.js, 0, 0))
>x : Symbol(x, Decl(npmlog.js, 7, 23))

2 changes: 1 addition & 1 deletion tests/baselines/reference/moduleExportAssignment2.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ var npm = module.exports = function (tree) {
module.exports.asReadInstalled = function (tree) {
>module.exports.asReadInstalled : Symbol(asReadInstalled, Decl(npm.js, 1, 1))
>module.exports : Symbol(asReadInstalled, Decl(npm.js, 1, 1))
>module : Symbol(module, Decl(npm.js, 0, 9), Decl(npm.js, 1, 1))
>module : Symbol(module, Decl(npm.js, 0, 9))
>exports : Symbol("tests/cases/conformance/salsa/npm", Decl(npm.js, 0, 0))
>asReadInstalled : Symbol(asReadInstalled, Decl(npm.js, 1, 1))
>tree : Symbol(tree, Decl(npm.js, 2, 43))
Expand Down
2 changes: 1 addition & 1 deletion tests/baselines/reference/moduleExportAssignment3.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ module.exports = function x() { }

module.exports() // should be callable
>module.exports : Symbol("tests/cases/conformance/salsa/mod", Decl(mod.js, 0, 0))
>module : Symbol(module, Decl(mod.js, 0, 0), Decl(mod.js, 0, 33))
>module : Symbol(module, Decl(mod.js, 0, 0))
>exports : Symbol("tests/cases/conformance/salsa/mod", Decl(mod.js, 0, 0))

2 changes: 1 addition & 1 deletion tests/baselines/reference/moduleExportAssignment5.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = axios;
module.exports.default = axios;
>module.exports.default : Symbol(default, Decl(axios.js, 8, 23))
>module.exports : Symbol(default, Decl(axios.js, 8, 23))
>module : Symbol(module, Decl(axios.js, 7, 9), Decl(axios.js, 8, 23))
>module : Symbol(module, Decl(axios.js, 7, 9))
>exports : Symbol("tests/cases/conformance/salsa/axios", Decl(axios.js, 0, 0))
>default : Symbol(default, Decl(axios.js, 8, 23))
>axios : Symbol(axios, Decl(axios.js, 5, 3))
Expand Down
Loading