Skip to content

Fix Buffer.from uses to handle node 5.4.1 bug #25659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jul 14, 2018
Merged

Fix Buffer.from uses to handle node 5.4.1 bug #25659

1 commit merged into from
Jul 14, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Jul 13, 2018

Fixes #25652

@ghost ghost requested a review from minestarks July 13, 2018 23:40
minestarks
minestarks approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@minestarks minestarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit e25a23b into master Jul 14, 2018
@ghost ghost deleted the bufferFrom branch July 14, 2018 00:08
@mhegazy mhegazy mentioned this pull request Jul 16, 2018
Merged
@jakebailey jakebailey mentioned this pull request Mar 23, 2024
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@minestarks