Don't add import completion from a re-export in "./index" #23623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
| // Ignore something in `./index` or `../index` if it's not the original exporting module. | ||
| if (moduleFile && | ||
| exportedSymbol.parent !== moduleSymbol && | ||
| removeFileExtension(getBaseFileName(moduleFile.fileName)) === "index" && |
Member
There was a problem hiding this comment.
checking index.ts seems wrong. Wouldnt it depend on package.json and "main" field in there?
Author
There was a problem hiding this comment.
I don't think this issue is related to package.json existing.
Although we could generalize the fix to any re-export in the same or an ancestor directory without involving the name "index".
mhegazy
approved these changes
Apr 25, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23598 and #23011