Tighten heuristic for definite dts moduleness to check for syntactic default #22814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
force-pushed
the
require-syntatic-export-default
branch
from
26f5506 to
607a98d
Compare
alfaproject
reviewed
Mar 24, 2018
src/compiler/checker.ts
Outdated
| if (hasModifier(node, ModifierFlags.Default)) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Either one line, or two lines, but I think this is just as readable if you prefer
return isExportAssignment(node) && !node.isExportEquals
|| hasModifier(node, ModifierFlags.Default);
There was a problem hiding this comment.
+1 for @alfaproject suggestion.
mhegazy
approved these changes
Mar 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22812