Fix export * merging to not overwrite original members #2123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test? |
|
The problem shows up in incremental bind scenarios, e.g. if module "b" has an export * of the members of a module "a", then when "a" is modified, "b" will still show the old exported members of "a". Not sure how to construct such a test, but I have manually verified that the fix solves the problem. |
|
Ah, got it. In that case, you could use a fourslash test to verify this. |
|
👍 |
ahejlsberg
added a commit
that referenced
this pull request
Feb 24, 2015
Fix export * merging to not overwrite original members
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing the merged set of exports for an external module with
export *statements inadvertently overwrites the original set of exports. This PR fixes the issue.