Wrap getDefaultLibFileName API changes in a try/catch until TypeScript 1... #2122
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
change is ok so 👍 . However test failure looks odd |
|
👍 Test failure can be ignored. It has been fixed. |
…t 1.5 has shipped.
jramsay
force-pushed
the
getDefaultLibFileNameFix
branch
from
839e8b5 to
a16a955
Compare
jramsay
added a commit
that referenced
this pull request
Feb 24, 2015
Wrap getDefaultLibFileName API changes in a try/catch until TypeScript 1...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap getDefaultLibFileName API changes in a try/catch until TypeScript 1.5 has shipped as VS's ILanguageServiceHost did not previously include the compiler options parameter.