Skip to content

Improve Extract* unit test coverage and correctness #18829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2017
Merged

Improve Extract* unit test coverage and correctness #18829

merged 2 commits into from
Sep 28, 2017

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Sep 28, 2017

  1. For any input that is valid JS, also generate a JS baseline.
  2. Validate that all baselines are syntactically valid.

Supersedes #18627.

@amcasey amcasey mentioned this pull request Sep 28, 2017
Closed
@amcasey amcasey merged commit 8e4c559 into microsoft:master Sep 28, 2017
@amcasey amcasey deleted the JsExtractTests branch September 28, 2017 21:59
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@paulvanbrenk paulvanbrenk paulvanbrenk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amcasey @paulvanbrenk