Call dynamic import transform on expression used by export equal statement #18028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Aug 24, 2017
|
Please port this to release-2.5 |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Aug 25, 2017
…ement (microsoft#18028) * Call dynamic import transform on expression used by export equal statement * Use Debug.fail
rbuckton
reviewed
Aug 25, 2017
| currentModuleInfo.exportEquals.expression | ||
| ) | ||
| ); | ||
| const expressionResult = importCallExpressionVisitor(currentModuleInfo.exportEquals.expression); |
There was a problem hiding this comment.
This should have been visitNode(currentModuleInfo.exportEquals.expression, importCallExpressionVisitor, isExpression) as it does the necessary validation you're doing on 435-437 for you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16641