Add exported members of all project files in the global completion list #17851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getCompletionEntryDetails
…etSymbolsFromOtherSourceFileExports inside getCompletionData
…ntriesFromSymbols and to return value of getCompletionData
… symbolToOriginInfoMap (meaning there's an import action)
…bolsFromOtherSourceFileExports)
…pletionEntryDetails
…fter the implementation
… immediately after getImportDeclarations
…nce it from the getCodeActions lambda
…eActionForImport, update call sites, destructure it, use compilerOptions in getModuleSpecifierForNewImport
…ons and use the ambient one
…oImportCodeFixContext
…ons lambda into getCodeActionForImport
…odeActions lambda
…er parameter to calls to it
…iately below convertToImportCodeFixContext
…Info, call getCodeActionForImport
…Character in getCodeActionForImport
… importcompletions-rebase
ghost
mentioned this pull request
|
Superseded by #19069 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the rebased and updated version of #13921.
Exported members of all project files are included in the global completion list, regardless of whether that file was already imported by the current file.
For completion list items coming from a not-yet-imported file, the returned
CompletionEntrynow has a new propertyhasAction, indicating if the user commits it, additional code actions will be needed to avoid errors.To retrieve the related code actions, the editor should send a
CompletionDetailsrequest and read the newcodeActionsproperty.Fixes #7849