Type arguments to formatStringFromArgs as strings instead of implicitly stringifying #11709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
compiler_diagnostic_strings
branch
from
49b201e to
1f7f67d
Compare
mhegazy
reviewed
Oct 18, 2016
src/compiler/checker.ts
Outdated
| if (!type) { | ||
| if (isTupleType(parentType)) { | ||
| error(declaration, Diagnostics.Tuple_type_0_with_length_1_cannot_be_assigned_to_tuple_with_length_2, typeToString(parentType), getTypeReferenceArity(<TypeReference>parentType), pattern.elements.length); | ||
| error(declaration, Diagnostics.Tuple_type_0_with_length_1_cannot_be_assigned_to_tuple_with_length_2, |
Contributor
There was a problem hiding this comment.
this seems like an overkill to me. can we make it string|number instead?
ghost
force-pushed
the
compiler_diagnostic_strings
branch
from
ff285ca to
8dc9523
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some
[object Object]showing up while making new diagnostic messages. This will help catch that error.