Skip to content

Allow type and NS references to UMD globals from modules #10929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2016
Merged

Allow type and NS references to UMD globals from modules #10929

merged 1 commit into from
Sep 15, 2016

Conversation

@RyanCavanaugh
Copy link
Member

@RyanCavanaugh RyanCavanaugh commented Sep 14, 2016

Fixes #10638

@RyanCavanaugh
Copy link
Member Author

RyanCavanaugh commented Sep 14, 2016

Needs separate port to 2.0

mhegazy
mhegazy approved these changes Sep 14, 2016
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

RyanCavanaugh added a commit that referenced this pull request Sep 14, 2016
@RyanCavanaugh
Merge pull request #10930 from RyanCavanaugh/release-2.0
bca3493 
Cherry-pick #10929 to release-2.0
@RyanCavanaugh RyanCavanaugh merged commit 98a3fc5 into microsoft:master Sep 15, 2016
@RyanCavanaugh RyanCavanaugh deleted the fix10638 branch September 15, 2016 21:00
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RyanCavanaugh @mhegazy @msftclas