For JSX text, construct a single literal node "foo bar" instead of "foo" + " " + "bar"
#10782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`"foo" + " " + "bar"`.
ghost
assigned
Member
|
Is there an issue tracking this? |
Author
|
This is not a bug. The output was just unnecessarily complicated. |
Member
|
FWIW Babel used to emit the |
Contributor
|
@Andy-MS there are some failing tests in this PR. |
src/compiler/transformers/jsx.ts
Outdated
| // when it emits the literal. We do, however, need to decode JSX entities. | ||
| parts.push(createLiteral(decodeEntities(part))); | ||
| const part = decodeEntities(text.substr(firstNonWhitespace, lastNonWhitespace - firstNonWhitespace + 1)); | ||
| acc = acc === undefined ? part : acc + " " + part; |
Member
There was a problem hiding this comment.
If you write
<div>
hello\
world
</div>What is the output?
Author
There was a problem hiding this comment.
It will be properly escaped: "hello\\ world".
Member
|
CI's failing again |
rbuckton
approved these changes
Jan 5, 2017
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.