Properly move baseline files #10439
Merged
Properly move baseline files #10439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakefile.js
Outdated
| var files = fs.readdirSync(sourceFolder); | ||
| var deleteEnding = '.delete'; | ||
| for (var i in files) { | ||
| var filename = path.basename(files[i]); |
Member
There was a problem hiding this comment.
Replace with var filename = files[i].substr(sourceFolder.length + 1). (May need to call path.resolve on sourceFolder and files[i] first.) As it stands, any tests in subfolders (which is a thing for projects tests!) will get baselined up to the top (and then be missing).
Member
Author
There was a problem hiding this comment.
These are actually already filename-only
RyanCavanaugh
force-pushed
the
fixJakeBaselineAccept
branch
from
f3c65ee to
6c60e5b
Compare
Member
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bad baseline behavior