Support twoslash directives for TsConfigOnlyOption
and its list
#3425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for twoslash directives (e.g.,
@path
) forTsConfigOnlyOption
and its list.Currently, twoslasher doesn't correctly handle the cases where
type
is"object"
. This code example triggers a runtime exception:TypeError: optMap.get is not a function
This problem comes from missing internal API types (
ts.optionDeclarations
isany
).I've added a patch to manage those type definitions in a single project (ts-internals) and added handling for missing cases based on them. Due to type consistency requirements, twoslasher now throws an error when an option with a list of booleans is passed, but that shouldn't be a problem since it's unreachable.
Related: #1555
Related: shikijs/twoslash#197 (comment)