Skip to content

Hide "Was this page helpful?" popup from focus when not visible #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Hide "Was this page helpful?" popup from focus when not visible #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa21681
Hide "Was this page helpful?" popup from focus
quiteolly Feb 15, 2022
22c5711
Hide "Was this page helpful?" popup from focus
quiteolly Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/templates/documentation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const HandbookTemplate: React.FC<Props> = (props) => {
<section id="doc-layout" >
<SidebarToggleButton />

<div className="page-popup" id="page-helpful-popup" style={{ opacity: 0 }}>
<div className="page-popup" id="page-helpful-popup" style={{ opacity: 0, visibility: 'hidden' }}>
<p>Was this page helpful?</p>
<div>
<button className="first" id="like-button-popup" title="Like this page"><LikeUnfilledSVG /></button>
Expand Down
2 changes: 2 additions & 0 deletions packages/typescriptlang-org/src/templates/scripts/setupLikeDislikeButtons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,13 @@ export const setupLikeDislikeButtons = (slug: string, i: any) => {
if (popup.style.opacity != popupOpacity) {
// popup.style.display = bottomOfWindow ? "block" : "none"
popup.style.opacity = popupOpacity
popup.style.visibility = bottomOfWindow ? "visible" : "hidden"
}

const navOpacity = bottomOfWindow ? "0" : "1"
if (nav.style.opacity != navOpacity) {
nav.style.opacity = navOpacity
nav.style.visibility = bottomOfWindow ? "hidden" : "visible"
}
},
{ passive: true, capture: true }
Expand Down