Use this: this in event handlers in mixin types and this: Window & typeof globalThis #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peof globalThis in global event handlers
orta
approved these changes
Jan 13, 2021
Contributor
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
This reads good to me. I've rebased some changes which will test this against the compiler's test suite, so Danger might have something to say - we'll see.
sandersn
approved these changes
Feb 23, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I think this is a good idea, but can you first create a PR on the Typescript repo to test performance?
Contributor
|
Is there a PR or can I go ahead and open one? |
Member
|
No, I'm pretty sure there's no PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in global event handlers.
Should fix microsoft/TypeScript#39057