Skip to content

fix inaccurate overrides for CSSOM #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019
Merged

fix inaccurate overrides for CSSOM #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5214,8 +5214,8 @@ interface Element extends Node, ParentNode, NonDocumentTypeChildNode, ChildNode,
getAttributeNames(): string[];
getAttributeNode(name: string): Attr | null;
getAttributeNodeNS(namespaceURI: string, localName: string): Attr | null;
getBoundingClientRect(): ClientRect | DOMRect;
getClientRects(): ClientRectList | DOMRectList;
getBoundingClientRect(): DOMRect;
getClientRects(): DOMRectList;
/**
* Returns a HTMLCollection of the elements in the object on which the method was invoked (a document or an element) that have all the classes given by classNames. The classNames argument is interpreted as a space-separated list of classes.
*/
Expand Down Expand Up @@ -9772,11 +9772,11 @@ declare var IntersectionObserver: {

/** This Intersection Observer API interface describes the intersection between the target element and its root container at a specific moment of transition. */
interface IntersectionObserverEntry {
readonly boundingClientRect: ClientRect | DOMRect;
readonly boundingClientRect: DOMRectReadOnly;
readonly intersectionRatio: number;
readonly intersectionRect: ClientRect | DOMRect;
readonly intersectionRect: DOMRectReadOnly;
readonly isIntersecting: boolean;
readonly rootBounds: ClientRect | DOMRect | null;
readonly rootBounds: DOMRectReadOnly | null;
readonly target: Element;
readonly time: number;
}
Expand Down Expand Up @@ -12588,8 +12588,8 @@ interface Range extends AbstractRange {
deleteContents(): void;
detach(): void;
extractContents(): DocumentFragment;
getBoundingClientRect(): ClientRect | DOMRect;
getClientRects(): ClientRectList | DOMRectList;
getBoundingClientRect(): DOMRect;
getClientRects(): DOMRectList;
insertNode(node: Node): void;
/**
* Returns whether range intersects node.
Expand Down
53 changes: 0 additions & 53 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,18 +1180,6 @@
"name": "Element",
"methods": {
"method": {
"getBoundingClientRect": {
"name": "getBoundingClientRect",
"override-signatures": [
"getBoundingClientRect(): ClientRect | DOMRect"
]
},
"getClientRects": {
"name": "getClientRects",
"override-signatures": [
"getClientRects(): ClientRectList | DOMRectList"
]
},
"getAttributeNodeNS": {
"name": "getAttributeNodeNS",
"override-signatures": [
Expand Down Expand Up @@ -1716,47 +1704,6 @@
]
}
},
"IntersectionObserverEntry": {
"name": "IntersectionObserverEntry",
"properties": {
"property": {
"boundingClientRect": {
"name": "boundingClientRect",
"read-only": 1,
"override-type": "ClientRect | DOMRect"
},
"intersectionRect": {
"name": "intersectionRect",
"read-only": 1,
"override-type": "ClientRect | DOMRect"
},
"rootBounds": {
"name": "rootBounds",
"read-only": 1,
"override-type": "ClientRect | DOMRect"
}
}
}
},
"Range": {
"name": "Range",
"methods": {
"method": {
"getBoundingClientRect": {
"name": "getBoundingClientRect",
"override-signatures": [
"getBoundingClientRect(): ClientRect | DOMRect"
]
},
"getClientRects": {
"name": "getClientRects",
"override-signatures": [
"getClientRects(): ClientRectList | DOMRectList"
]
}
}
}
},
"WebSocket": {
"name": "WebSocket",
"methods": {
Expand Down