Unwrap Promise from param types #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
requested changes
Jan 24, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Couple of questions about how the code changes map to the changes in *.generated.d.ts.
| p = { name: p.name, type: [p.subtype!, p] } | ||
| } | ||
| const isOptional = !p.variadic && p.optional; | ||
| const pType = isOptional ? convertDomTypeToTsType(p) : convertDomTypeToNullableTsType(p); |
Member
There was a problem hiding this comment.
I don't understand what change this is expected to have on *.generated.d.ts. Is it the change of Promise<any> to any? If so, why?
If there is no change in generated files, then is this just extra cleanup?
Contributor
Author
There was a problem hiding this comment.
Yes, this is intended to be an extra cleanup, but now I think it's better to just remove convertDomTypeToNullableTsType because convertDomTypeToTsType now also can process nullable types. Currently convertDomTypeToNullableTsType looks redundant.
Contributor
Author
There was a problem hiding this comment.
Reverted this line and moved it to #641.
sandersn
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#17804
Because the Web IDL spec says JS->IDL conversion internally uses
Promise.resolve().