Skip to content

Conversation

@zhengbli
Copy link
Contributor

Add the baselines to identify changes in generated files.
Fix #3.

Change the word "dump" to "emit"; Move all the special definitions out
of the source code to external json files, to make sending PRs easier;
other clean-ups.
@sandersn
Copy link
Member

Looks OK. Are you planning to add the test infrastructure later? As is, this half-fixes #3.

@zhengbli
Copy link
Contributor Author

Right, it should be better if I can add Travis CI. Working on it.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 15, 2015

👍

@mhegazy
Copy link
Contributor

mhegazy commented Oct 15, 2015

we should add a note about the baselines in the readme.md

@zhengbli zhengbli changed the title Add baselines Add baselines and CI integration Oct 23, 2015
zhengbli added a commit that referenced this pull request Oct 23, 2015
Add baselines and CI integration
@zhengbli zhengbli merged commit db36521 into master Oct 23, 2015
@zhengbli zhengbli deleted the addBaseline branch October 23, 2015 09:23
jeffryang24 added a commit to jeffryang24/TSJS-lib-generator that referenced this pull request Jun 15, 2019
sandersn pushed a commit that referenced this pull request Jun 20, 2019
* chore: add system state and capabilities whatwg spec

* feat(idl): add generated widl and commentmap file

* chore(baselines): add generated type

* chore: update baseline

* refactor(baseline): add removed ms-interfaces

* refactor(idlSources): sort idlsource

* refactor(addedTypes): add missing interfaces and MS-specific interfaces

* refactor(overridingTypes): override navigator interface

* refactor(overridingTypes): add missing ms-specific properties in Navigator interface

* chore: update baselines

* refactor(addedTypes): remove redundant interfaces

* chore: update baselines #2

* refactor(addedTypes): remove MSLaunchUriCallback interface

* refactor(knownTypes): add MSLaunchUriCallback inside Window field

* chore: update baselines #3 (with node 12)

* refactor(overridingTypes): restore NavigatorBeacon, activeVRDisplays, and getVRDisplays

* chore: update baselines #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants