Fix type declarations for "setSelectionRange" API #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuckAMayzing
added a commit
to BuckAMayzing/TSJS-lib-generator
that referenced
this pull request
Aug 3, 2019
Regression from microsoft#340 Addresses microsoft/TypeScript#32449
BuckAMayzing
added a commit
to BuckAMayzing/TSJS-lib-generator
that referenced
this pull request
Aug 3, 2019
Regression from microsoft#340 Addresses microsoft/TypeScript#32449
sandersn
pushed a commit
that referenced
this pull request
Nov 14, 2019
Regression from #340 Addresses microsoft/TypeScript#32449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#20419.
The
startandendparameters of theHTMLInputElement.setSelectionRange()API are not optional.In addition, the
directionparameter only accepts one of three string values, which is why it's now typed using string literal types.