This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 179
lookup table code #611
Merged
Merged
lookup table code #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msoeken
suggested changes
Aug 19, 2022
Member
msoeken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. That looks really great! I left some comments.
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Co-authored-by: Mathias Soeken <[email protected]>
Moved potential efficiency comments of fanning out control qubits from summary to inside the code
Split original summary to summary and remarks
msoeken
approved these changes
Aug 22, 2022
Member
msoeken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for incorporating the comments. I have left one more comment that includes an example for the docs.
msoeken
reviewed
Aug 22, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
Woohoo!!
Envoyé depuis Yahoo Mail pour Android
Le mar., août 23, 2022 à 8:30, Mathias ***@***.***> a écrit:
Merged #611 into main.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #607