This repository was archived by the owner on Jan 12, 2024. It is now read-only.
ApplyWindowed #603
Merged
ApplyWindowed #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies an operation windowing over input but with const target qubits
|
|
adrianleh
force-pushed
the
feature/apply-windowed
branch
from
2f0fefd to
3f87f06
Compare
See comment on microsoft#602 by @cgranade
adrianleh
force-pushed
the
feature/apply-windowed
branch
from
888d2bf to
0e6e244
Compare
tcNickolas
suggested changes
Jul 19, 2022
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
I left some comments for the main operation, the docs ones can be safely copied to the three other ones. For the sample, I would not copy it over, but rather add a reference from the variants to the first operation so that the example in it can be discovered:
/// # See Also
/// - Microsoft.Quantum.Arrays.ApplyWindowed
msoeken
approved these changes
Jul 19, 2022
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Thanks for the contribution @adrianleh
tcNickolas
approved these changes
Jul 19, 2022
Contributor
tcNickolas
left a comment
tcNickolas
left a comment
There was a problem hiding this comment.
Looks good, just one small formatting comment
tcNickolas
reviewed
Jul 19, 2022
Co-authored-by: Mariia Mykhailova <[email protected]>
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #602