This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Implements #442 #552
Merged
Implements #442 #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
approved these changes
Apr 6, 2022
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Approved with minor comments. Thanks!
| /// # See Also | ||
| /// - Microsoft.Quantum.Canon.SinglyControlledA | ||
| function SinglyControlled<'T>(op : 'T => Unit is Ctl) : (Qubit, 'T) => Unit is Ctl { | ||
| return ApplySinglyControlled(op, _, _); |
Contributor
There was a problem hiding this comment.
You may be able to write this as a lambda now:
Suggested change
| return ApplySinglyControlled(op, _, _); | |
| return (ctrl, originalInput) => Controlled op([ctrl], originalInput); |
Not sure if that generates the right characteristics, as I've not tested that yet, sorry.
Member
Author
There was a problem hiding this comment.
That's awesome! And the recent commit confirms it works.
| open Microsoft.Quantum.Intrinsic; | ||
|
|
||
| @Test("ToffoliSimulator") | ||
| operation TestSinglyControlled() : Unit { |
Contributor
There was a problem hiding this comment.
For testing, this is great, but I may also suggest an AssertOperationsEqualReferenced call for something like H:
AssertOperationsEqualReferenced(2,
(qs) => SinglyControlled(H)(qs[0], qs[1]),
(qs) => Controlled H([qs[0]], qs[1])
);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.