This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 179
API review March 2022 #535
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6694867
API review meeting notes.
msoeken 93f1f05
Merge branch 'main' into msoeken/api-review-2203
msoeken 03d4d7b
Merge branch 'main' into msoeken/api-review-2203
msoeken 08ca545
Update Design/meetings/2022/api-design-2022-03.md
msoeken 105ac3b
Apply suggestions from code review
msoeken c589b24
Merge branch 'main' into msoeken/api-review-2203
msoeken 9e10368
Update consensus.
msoeken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Q# API Design Discussions / March 2022 | ||
|
|
||
| Reviewers (in order by username): . | ||
|
|
||
| ## Agenda | ||
|
|
||
| - https://github.com/microsoft/QuantumLibraries/issues/471 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/442 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/423 | ||
| - https://github.com/microsoft/QuantumLibraries/issues/515 | ||
|
|
||
| ## Discussion | ||
|
|
||
| ### Multivariate stochastic optimization | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/471 | ||
|
|
||
| **Reviews**: | ||
| * @msoeken, *approve* | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Approved (incl. implicit approval from proposal author) | ||
|
|
||
| --- | ||
|
|
||
| ### New functions for singly controlled operations | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/442 | ||
|
|
||
| **Reviews**: | ||
| * @tcNickolas, *approve*, left a couple of small comments in the issue | ||
| * @msoeken, *approve* | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Approved (incl. implicit approval from proposal author) | ||
|
|
||
| --- | ||
|
|
||
| ### Simple and consistent arithmetic API | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/423 | ||
|
|
||
| **Reviews**: | ||
|
|
||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Postponed (no additional review was provided) | ||
|
|
||
| --- | ||
|
|
||
| ### New operation: AmplitudeTransduction | ||
|
|
||
| **Proposal**: https://github.com/microsoft/QuantumLibraries/issues/515 | ||
|
|
||
| **Reviews**: | ||
| @msoeken, *approve* | ||
| > Please add a bullet point including your alias, your review result (*approve*, *reject*, *comment*), and a comment (optional when result is *approve*). Alternatively, add a line to the PR discussion incl. a reference to this issue. | ||
|
|
||
| **Consensus**: Approved (incl. implicit approval from proposal author) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.