This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix overestimation in MachineLearning.NQubitsRequired #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry for bumping, but any reviews or updates for this? |
|
@PhysSong thanks for opening this PR! Apologies for the late reply; I will take a look this afternoon. |
msoeken
approved these changes
Mar 9, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270.
The function sometimes overestimated the number of required qubits because the
forloop increasednQubitsRequiredby 1 when it shouldn't.