Resync Updates from Master Codebase. #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.1.17:
Fix for Request ID not reflecting correctly for some requests.
Fix for RequestAdditionalHeadersAsync interface not being forwarded to Cloned copies of DVSC. GitHub Reported - Fix #419
Fix for Clone being called concurrently causing unnecessary calls to dataverse. GitHub reported - Fix #422
Fix for invalid filenames and paths being created for token cache path when using user interactive mode. Git Hub reported - Fix #406
RENAME (Possible breaking change) MaxBufferPoolSizeOveride parameter name spelling issue, corrected to MaxBufferPoolSizeOverride
This pull request includes a wide range of changes to improve the functionality and maintainability of the codebase. The most important changes include adding new methods and improving exception handling in the
ConnectionManager.csfile, introducing a newNotification::Cacheclass for interacting with a cache, and adding new methods and attributes to theNotificationclass for extracting information from GitHub notifications.Main interface changes:
src/GeneralTools/DataverseClient/ConnectControl/ConnectionManager.cs: Various changes to improve theConnectionManager.csfile, including handling cases where the organization service URL is not a valid URI, adding validation for server URL and username, and introducing exception handling in theQueryOnlineServerListmethod. [1] [2] [3] [4] [5] [6] [7] [8] [9]Configuration improvements:
src/nuspecs/Microsoft.PowerPlatform.Dataverse.Client.ReleaseNotes.txt: Updated release notes with fixes for various issues.Testing improvements:
src/GeneralTools/DataverseClient/UnitTests/CdsClient_Core_Tests/ServiceClientTests.cs: Added new tests to theNotification::Cleanerclass covering various methods. (Fe5c9d27)Other important changes:
src/GeneralTools/DataverseClient/Client/Utils/Utils.cs: AddedCleanUpPotentialFileNamemethod toUtils.csto remove invalid characters from a potential file name.src/GeneralTools/DataverseClient/Client/ServiceClient.cs: Modified theServiceClient.csfile to improve the handling of theStopwatchobject and introduce synchronization for clone operations. [1] [2] [3] [4] [5] [6] [7]Please note that the changes mentioned above are just a selection of the most important ones.