Resync from mainline. #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to the
DataverseClientproject includes a variety of bug fixes and improvements. The most important changes include fixing a bug related to token cache file creation and adding two new properties to theOrganizationDetailandDiscoveryServerobjects.Bug fixes:
src/GeneralTools/DataverseClient/Client/Auth/TokenCache/FileBackedTokenCacheHints.cs: Fixed a bug where the token cache file couldn't be created if the host name contained invalid characters by adding a check to replace invalid characters with underscores.src/nuspecs/Microsoft.PowerPlatform.Dataverse.Client.ReleaseNotes.txt: Fixed a bug related to token cache file creation and updated dependency versions for System.Text.Json and Microsoft.Identity.Client.New features:
src/GeneralTools/DataverseClient/Client/ConnectionService.cs: Added two new properties,SchemaTypeandOrganizationType, to both theOrganizationDetailandDiscoveryServerobjects. [1] [2]src/GeneralTools/DataverseClient/Client/Model/GlobalDiscoveryModel.cs: Added a new property to theGlobalDiscoveryInstanceModelclass and updated the using statements in theGlobalDiscoveryModelclass. [1] [2]Code improvements:
Fix to include #384
Fix to include #406
src/GeneralTools/DataverseClient/Client/Utils/Utils.cs: Removed an unnecessary semicolon in theGetDiscoveryServerByUrimethod.