Fix anyOf and oneOf v2 serialization #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riting either as allOf
millicentachieng
changed the title
millicentachieng
requested review from
MaggieKimani1,
baywet,
darrelmiller,
irvinesunday,
peombwa and
zengin
as code owners
baywet
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
When converting a schema to Open API v2, which contains either
oneOforanyOf, we add them asallOfif anallOfdoesn't already exist, since both are not supported in v2.The existing implementation failed to check if
anyOforoneOfexisted before attempting to addallOf. This PR adds the check.