Skip to content

Add --clean-output parameter to allow overwriting existing files #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Add --clean-output parameter to allow overwriting existing files #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7defeda
Add a --clean-output parameter for overwriting existing files
MaggieKimani1 Mar 8, 2022
1ec5177
Merge remote-tracking branch 'origin/vnext' into enhancement/add-clea…
MaggieKimani1 Mar 8, 2022
b785cb9
Add a condition for ensuring the output file path exists before clean…
MaggieKimani1 Mar 9, 2022
e31c9de
Merge branch 'vnext' into enhancement/add-clean-output-param
MaggieKimani1 Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Microsoft.OpenApi.Hidi/OpenApiService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public static async Task<int> ProcessOpenApiDocument(
string openapi,
string csdl,
FileInfo output,
bool cleanoutput,
string? version,
OpenApiFormat? format,
LogLevel loglevel,
Expand All @@ -56,6 +57,10 @@ CancellationToken cancellationToken
{
throw new ArgumentNullException(nameof(output));
}
if (cleanoutput && output.Exists)
{
output.Delete();
}
if (output.Exists)
{
throw new IOException($"The file {output} already exists. Please input a new file path.");
Expand Down
6 changes: 5 additions & 1 deletion src/Microsoft.OpenApi.Hidi/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ static async Task<int> Main(string[] args)
var outputOption = new Option<FileInfo>("--output", () => new FileInfo("./output"), "The output directory path for the generated file.") { Arity = ArgumentArity.ZeroOrOne };
outputOption.AddAlias("-o");

var cleanOutputOption = new Option<bool>("--clean-output", "Overwrite an existing file");
cleanOutputOption.AddAlias("-co");

var versionOption = new Option<string?>("--version", "OpenAPI specification version");
versionOption.AddAlias("-v");

Expand Down Expand Up @@ -63,6 +66,7 @@ static async Task<int> Main(string[] args)
descriptionOption,
csdlOption,
outputOption,
cleanOutputOption,
versionOption,
formatOption,
logLevelOption,
Expand All @@ -73,7 +77,7 @@ static async Task<int> Main(string[] args)
resolveExternalOption,
};

transformCommand.SetHandler<string, string, FileInfo, string?, OpenApiFormat?, LogLevel, bool, bool, string, string, string, CancellationToken> (
transformCommand.SetHandler<string, string, FileInfo, bool, string?, OpenApiFormat?, LogLevel, bool, bool, string, string, string, CancellationToken> (
OpenApiService.ProcessOpenApiDocument, descriptionOption, csdlOption, outputOption, versionOption, formatOption, logLevelOption, inlineOption, resolveExternalOption, filterByOperationIdsOption, filterByTagsOption, filterByCollectionOption);

rootCommand.Add(transformCommand);
Expand Down