Skip to content

Fix round-tripping of empty media type objects and parsing of encoding style. #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix round-tripping of empty media type objects and parsing of encoding style. #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e27c0e7
Fixed parsing of encoding style
darrelmiller Jan 23, 2022
666a94e
Allow empty objects to be considered valid media type objects
darrelmiller Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Microsoft.OpenApi.Readers/V3/OpenApiEncodingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,7 @@ internal static partial class OpenApiV3Deserializer
{
"style", (o, n) =>
{
ParameterStyle style;
if (Enum.TryParse(n.GetScalarValue(), out style))
{
o.Style = style;
}
else
{
o.Style = null;
}
o.Style = n.GetScalarValue().GetEnumFromDisplayName<ParameterStyle>();
}
},
{
Expand Down
5 changes: 0 additions & 5 deletions src/Microsoft.OpenApi.Readers/V3/OpenApiMediaTypeDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,6 @@ public static OpenApiMediaType LoadMediaType(ParseNode node)
{
var mapNode = node.CheckMapNode(OpenApiConstants.Content);

if (!mapNode.Any())
{
return null;
}

var mediaType = new OpenApiMediaType();

ParseMap(mapNode, mediaType, _mediaTypeFixedFields, _mediaTypePatternFields);
Expand Down