-
Notifications
You must be signed in to change notification settings - Fork 279
Updates ci-build.yml to deploy Commandline tool to Nuget #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.azure-pipelines/ci-build.yml
Outdated
| - task: MSBuild@1 | ||
| displayName: 'Pack OpenAPI.Tool' | ||
| inputs: | ||
| solution: src/Microsoft.OpenApi.Tool/Microsoft.OpenApi.Tool.csproj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NuGet package will be named Microsoft.OpenApi.Tool. Is there a more specific name for this tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my conversation with @darrelmiller, we're still brainstorming whether to retain it as is or find a more descriptive name for the tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe OpenApiCli.Tool @darrelmiller ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very close to being convinced we should call this Microsoft.hidi as hidi is the Swahili word for Convert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do either of you foresee this tool with future functionality that does something other than convert and validate? If this is foreseeable, then perhaps we leave it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is going to slice. It may also convert from CSDL to OpenAPI. It may in the future be able to apply overlays. I ran the name "hidi" up the chain and we have support from PMs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then, Microsoft.OpenApi.Hidi or Microsoft.Hidi? I'm more for the first, but think both are fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning the second. However, I have been asked to chat with the marketing folks to make sure they are ok with the hidi and kiota names. I'm going try and do that tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge the PR and get approval before we push a release out.
This PR:
OpenApi.Tool, a commandline tool that enables processing of OpenAPI documents through validation, supports conversion for different file formats e.g fromjsontoyamland vice versa, and also supports filtering/slicing of OpenApi documents into smaller subset documents based on OperationIds and tags provided.Fixes #630