Adds setting to configure leaving stream open #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Jun 7, 2021
| public OpenApiDocument Read(Stream input, out OpenApiDiagnostic diagnostic) | ||
| { | ||
| using (var reader = new StreamReader(input)) | ||
| if (_settings.LeaveStreamOpen) |
There was a problem hiding this comment.
var reader = new StreamReader(input);
var result = new OpenApiTextReaderReader(_settings).Read(reader, out diagnostic);
if (!_settings.LeaveStreamOpen)
reader.Dispose();
return result;There was a problem hiding this comment.
Yes. Much cleaner!
There was a problem hiding this comment.
I like brackets after if statements though, even for one-liners 😄
There was a problem hiding this comment.
I won't fight coding preferences. It seems that I'm the only one on the team to like one liners with no brackets 😅
- Remove default assignment of false boolean to setting - Code simplification
…ble' into is/OpenApiStreamReader-configurable
darrelmiller
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #530
Closes https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/583
This PR:
booleansetting inOpenApiReaderSettings.cs:LeaveStreamOpento flag whether or not to leave the stream object open after reading from anOpenApiStreamReaderobject.Creating a
StreamReaderobject within ausingstatement closes thestreamwhen theDispose()method of theStreamReaderis called.OpenApiStreamReadertests to validate setting theLeaveStreamOpensetting to eithertrueorfalse.