Query Parameters Serialization - Explode doesn't respect the default value

[simon-pearson]

• A proposed fix for issue Query Parameters Serialization - Explode don't respect the default value. #479.
• Add a unit test covering this behavior.

[safepage]

I understand this fix but the serialization code looks wrong:

writer.WriteProperty(OpenApiConstants.Explode, Explode, Style.HasValue && Style.Value == ParameterStyle.Form);

Maybe it should be:

writer.WriteProperty(OpenApiConstants.Explode, _explode);

Then the serialized model would reflect the actual values read in (as _explode is a nullable bool?).

Also, there is now an inconsistency as Style is also not set to a default value:
“Default values (based on value of in): for query - form; for path - simple; for header - simple; for cookie - form.”

[darrelmiller]

@safepage The serialization code will write out any value that was read because that is what the Explode property does by default (unless it is the default value). Only if Explode has not be set, i.e. _explode is null will the default value be used. If the Explode property returns a "default" then it will match with the default passed as the third parameter to WriteProperty and no Explode value will be written to the output. This does mean that if a input document redundantly provides the default value, then it will be missing in the output.