Corrected expected ordering for skipped unit tests. #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AndrewRissing
commented
Jul 26, 2020
| OpenApiDifferenceOperation = OpenApiDifferenceOperation.Update, | ||
| OpenApiComparedElementType = typeof(string), | ||
| TargetValue = "image/jpeg", | ||
| SourceValue = "image/png, image/jpeg" |
Contributor
Author
There was a problem hiding this comment.
The below changes are just reordering of expected differences to align to the current output. Since the tests expect an explicit ordering, I assume these were taken out due to ordering changes in the code base that caused these tests to break.
I verified the correct ordering for the individual comparer's and assumed the overall OpenApiComparerTests suffered the same issue. If there is some underlying change that would warrant digging into those details, let me know and I can run it down.
Outside of the above, I found a few cases where a OpenApiComparedElementType of Uri was provided a TargetValue and SourceValue of type string rather than Uri, which I corrected as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.