-
Notifications
You must be signed in to change notification settings - Fork 279
Serialize explode value properly on parameters with style "form" #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize explode value properly on parameters with style "form" #404
Conversation
When a parameter has the style set to "form" and explode set to false, the v3 serializer will not write out the value for explode. Swagger UI then defaults the explode value to true, since it is not specified and that is the correct default value when the style is set to "form". The OpenAPI spec for this is right around here: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#fixed-fields-10
|
Nice catch. It is this part of the spec that we were not doing properly:
Your changes look good to me. If you can sign the CLA, we can get these changes merged in. |
|
There is similar logic in the |
|
Any chance of merging this sometime soon? |
|
@mapitman I will look into this next week. Sorry for the delay |
|
I am interested in this fix as well. Any update? |
|
I need to get a certificate updated before I can redeploy. Working on it. |
|
Appreciate you're busy and doing this for the community, @darrelmiller , but any update? |
|
@boekabart My apologies. I have the new cert. Now I need to actually deploy it. I will try and do this later today. |
When a parameter has the style set to "form" and explode set to false,
the v3 serializer will not write out the value for explode. Swagger UI
then defaults the explode value to true, since it is not specified and
that is the correct default value when the style is set to "form". The
OpenAPI spec for this is right around here:
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md#fixed-fields-10
I'll be glad to make any changes required to get his accepted.