fixes#319 - V2Deserializer should handle invalid host value gracefully #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi.Readers/V2/OpenApiDocumentDeserializer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiServerTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenApi.Readers.Tests/V2Tests/OpenApiServerTests.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for the PR! Once you fix the issues in the comments above, I'll approve and merge this in. |
…lue-gracefully' of https://github.com/senthilkumarmohan/OpenAPI.NET into bugfix#319-V2Deserializer-should-handle-invalid-host-value-gracefully
…valid-host-value-gracefully
…lue-gracefully' of https://github.com/senthilkumarmohan/OpenAPI.NET into bugfix#319-V2Deserializer-should-handle-invalid-host-value-gracefully
Contributor
Author
|
@PerthCharern thanks for the review. I have fixed the issues as per the comments. |
PerthCharern
approved these changes
Oct 31, 2018
Contributor
|
Looking good! Thanks again! |
This was referenced Dec 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #319