Skip to content

Fix for regex to potentially prevent catastrophic backtracking #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2018
Merged

Fix for regex to potentially prevent catastrophic backtracking #248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31574c9
Fix for regex
darrelmiller May 4, 2018
b95f137
Dummy change to trigger rebuild
darrelmiller May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.OpenApi/Validations/Rules/OpenApiResponsesRules.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public static class OpenApiResponsesRules
});

/// <summary>
/// The response key must either be "default" or an HTTP status code (1xx, 2xx, 3xx, 4xx, 5xx)
/// The response key must either be "default" or an HTTP status code (1xx, 2xx, 3xx, 4xx, 5xx).
/// </summary>
public static ValidationRule<OpenApiResponses> ResponsesMustBeIdentifiedByDefaultOrStatusCode =>
new ValidationRule<OpenApiResponses>(
Expand All @@ -38,7 +38,7 @@ public static class OpenApiResponsesRules
{
context.Enter(key);

if (key != "default" && !Regex.IsMatch(key, "^[1-5]([0-9][0-9]|XX)$"))
if (key != "default" && !Regex.IsMatch(key, "^[1-5](?>[0-9]{2}|XX)$"))
{
context.CreateError(nameof(ResponsesMustBeIdentifiedByDefaultOrStatusCode),
"Responses key must be 'default', an HTTP status code, " +
Expand All @@ -50,4 +50,4 @@ public static class OpenApiResponsesRules
}
});
}
}
}