Fix for writing DateTimeOffset values

[darrelmiller]

Addresses #243

[PerthCharern]

    public void ParseScalarIntegertAsAnyShouldSucceed()

nit, not related to your change but I just happened to notice it. Could you remove the t? #Closed

---

Refers to: test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiAnyTests.cs:83 in e4c7a0e. [](commit_id = e4c7a0e, deletion_comment = False)

[PerthCharern]

@ [](start = 44, length = 1)

nit, @ not needed #Closed

[PerthCharern]

        }

On a related note, should we also call long.TryParse in the ValueNode in the Reader?

https://github.com/Microsoft/OpenAPI.NET/blob/bd61abdfee72445d52312d70f04db087e6d30cf9/src/Microsoft.OpenApi.Readers/ParseNodes/ValueNode.cs. #Closed

---

Refers to: src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs:211 in e4c7a0e. [](commit_id = e4c7a0e, deletion_comment = False)

[PerthCharern]

[darrelmiller]

Probably a good idea. I will add that.

…

________________________________ From: PerthCharern <[email protected]> Sent: Friday, April 27, 2018 12:32:35 PM To: Microsoft/OpenAPI.NET Cc: Darrel Miller; Author Subject: Re: [Microsoft/OpenAPI.NET] Fix for writing DateTimeOffset values (#246) } On a related note, should we also call long.TryParse in the ValueNode in the Reader? https://github.com/Microsoft/OpenAPI.NET/blob/bd61abdfee72445d52312d70f04db087e6d30cf9/src/Microsoft.OpenApi.Readers/ParseNodes/ValueNode.cs.

________________________________ Refers to: src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs:211 in e4c7a0e<e4c7a0e>. [](commit_id = e4c7a0e<e4c7a0e>, deletion_comment = False) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#246 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAbUzkhTiVQF5iWYh4YQrqEnPfv5OH5oks5ts0gjgaJpZM4Tqj88>. #Resolved

[darrelmiller]

@PerthCharern Any idea why we have this license/cla check that is holding up the PR?

[PerthCharern]

@darrelmiller

The check evaluates whether a CLA needs to be signed for Microsoft (based on various factors like contributor(s), size of the change, etc.)

I have seen cases where it occasionally hangs up indefinitely for some reason. In that case, the fastest way to resolve it is to commit a new whitespace change.

[darrelmiller]

@PerthCharern I knew what it was, I just couldn't understand why it was an issue. I'll try the whitespace trick.

[PerthCharern]

That I don't know. It started happening recently. I'll get in touch with the OSS team.