Fix formData/body parameter and consumes handling #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… body parameter. - Unit tests verify that serializing, deserializing, and re-deserializing all work as expected.
|
cc @talamram |
| } | ||
| }; | ||
|
|
||
| var consumes = context.GetFromTempStorage<List<string>>("operationconsumes") ?? |
There was a problem hiding this comment.
It is worth noting that this will import a valid V2 document correctly, but it will also create an invalid DOM if the media type is not a valid one. Validating this is going to be tricky, so I'm ok if we punt on checking for that.
There was a problem hiding this comment.
Agree. It’s a bit complicated to add “validation logic” into the reader at this point. I’d rather wait for your PR to be completed and we can retroactively clean-up these validation grey areas later.
darrelmiller
approved these changes
Jan 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the serialization and deserialization logic for V2 formData and body parameter.
V2 operation deserialization now respects the
consumesproperty.Unit tests verify that serializing, deserializing, and re-deserializing all work as expected.
Fix #178
Fix #179