Replace JsonSchema with OpenApiSchema #1787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d32cc1.
…ookups in the component registry
# Conflicts: # src/Microsoft.OpenApi/Models/OpenApiSchema.cs
…ookups in the component registry
…ft/OpenAPI.NET into mk/use-json-schema-model
MaggieKimani1
requested review from
andrueastman,
coseguera,
darrelmiller,
irvinesunday and
millicentachieng
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ExternalResource = externalResource | ||
| }; | ||
|
|
||
| Reference = _reference; |
Check warning
Code scanning / CodeQL
Virtual call in constructor or destructor
Comment on lines
91
to
107
| foreach (var kvp in anyObject) | ||
| { | ||
| foreach (var detail in results.Details) | ||
| var key = kvp.Key; | ||
| context.Enter(key); | ||
|
|
||
| if (schema.Properties != null && | ||
| schema.Properties.TryGetValue(key, out var property)) | ||
| { | ||
| if (detail.Errors != null && detail.Errors.Any()) | ||
| { | ||
| foreach (var error in detail.Errors) | ||
| { | ||
| if (!string.IsNullOrEmpty(error.Key) || !string.IsNullOrEmpty(error.Value.Trim())) | ||
| { | ||
| context.CreateWarning(ruleName, string.Format("{0} : {1} at {2}", error.Key, error.Value.Trim(), detail.InstanceLocation)); | ||
| } | ||
| } | ||
| } | ||
| ValidateDataTypeMismatch(context, ruleName, anyObject[key], property); | ||
| } | ||
| else | ||
| { | ||
| ValidateDataTypeMismatch(context, ruleName, anyObject[key], schema.AdditionalProperties); | ||
| } | ||
|
|
||
| context.Exit(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select
|
darrelmiller
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
JsonSchema.NETlibrary from the core and Readers projectJsonSchemaobject fromJsonSchema.NETwith our nativeOpenApiSchemaimplementation that supports all V2, V3, and V31-specific keywords.pattern propertieskeyword in line with JSON schema.exampleskeyword in theOpenApiSchemaobject in line with JSON schema as theexampleproperty has been deprecated in favor of it.$refto$idby:idas a locator when registering schemas in the registry and performing lookups during reference resolution.OpenApiSchemaReferenceobject that acts as a proxy for lazy schema reference resolutionJsonNodein place ofOpenApiAnyfor Enums and ExamplesIssues resolved
#1789
#1790
#1791
#1792
#1793