Skip to content

Add ValidationRuleSet.Remove #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jan 24, 2024
Merged

Add ValidationRuleSet.Remove #1535

merged 56 commits into from
Jan 24, 2024

Conversation

@LucGenetier
Copy link
Contributor

@LucGenetier LucGenetier commented Jan 21, 2024

No description provided.

baywet and others added 30 commits May 11, 2022 08:00
@baywet
Merge pull request microsoft#855 from microsoft/vnext
08b21d1 
hidi release
@baywet
Merge pull request microsoft#865 from microsoft/vnext
f918aba 
hidi release
@baywet
Merge pull request microsoft#871 from microsoft/vnext
b04aecd 
hidi release
@baywet
Merge pull request microsoft#899 from microsoft/vnext
fe8d4fa 
hidi release
@baywet
Merge pull request microsoft#914 from microsoft/vnext
5fe88e8 
hidi docker image release
@baywet
Merge pull request microsoft#917 from microsoft/vnext
98877ba 
docker workflow fix
@baywet
Merge pull request microsoft#931 from microsoft/vnext
6cf490e 
releases hidi
@baywet
Merge pull request microsoft#938 from microsoft/vnext
b2f53ee 
releasing hidi
@andrueastman
Merge pull request microsoft#947 from microsoft/vnext
67a6b07 
Releases Hidi
@darrelmiller
Merge pull request microsoft#958 from microsoft/vnext
35b5282 
Release Libs v1.4.0-preview1
@MaggieKimani1
Merge pull request microsoft#979 from microsoft/vnext
03ff377 
Release v1.4.0-preview2
@MaggieKimani1
Merge pull request microsoft#997 from microsoft/vnext
c382c22 
Release libs v1.4.0-preview3
@MaggieKimani1
Merge pull request microsoft#999 from microsoft/vnext
ddcdf25 
v1.4.0 release
@baywet
Merge pull request microsoft#1002 from microsoft/vnext
512c795 
Release `v1.4.1`
@irvinesunday
Merge pull request microsoft#1009 from microsoft/vnext
103ea84 
Merges `vnext` into `master`
@baywet
Merge pull request microsoft#1015 from microsoft/vnext
f6185b6 
releases hidi
@baywet
Merge pull request microsoft#1018 from microsoft/vnext
e6308a8 
releases hidi
@MaggieKimani1
Merge pull request microsoft#1023 from microsoft/vnext
5f8a702 
Release 1.4.3
@MaggieKimani1
Merge pull request microsoft#1037 from microsoft/vnext
d23ad22 
Release 1.4.4-preview1
@baywet
Merge pull request microsoft#1050 from microsoft/vnext
1b02c01 
Releases Hidi
@MaggieKimani1
Merge pull request microsoft#1084 from microsoft/vnext
656ac9a 
Release libs
@MaggieKimani1
Merge pull request microsoft#1086 from microsoft/vnext
40d67ac 
Merge dev into master
@baywet
Merge pull request microsoft#1100 from microsoft/vnext
0381437 
1.4.5 release to unblock kiota
@baywet
Merge pull request microsoft#1120 from microsoft/vnext
60c11ad 
master refresh
@MaggieKimani1
Merge pull request microsoft#1148 from microsoft/vnext
572b303 
1.6.0 release
@baywet
Merge pull request microsoft#1153 from microsoft/vnext
9c18762 
master refresh for hidi release
@baywet
Merge pull request microsoft#1161 from microsoft/vnext
bf7b8cf 
master refresh
@MaggieKimani1
Merge pull request microsoft#1170 from microsoft/vnext
e0b36a7 
Master refresh
@baywet
Merge pull request microsoft#1175 from microsoft/vnext
2605650 
hidi release
@MaggieKimani1
Merge pull request microsoft#1181 from microsoft/vnext
9155d11 
Merge dev into master
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2024
View reviewed changes
@baywet baywet changed the base branch from master to vnext January 22, 2024 15:11
baywet
baywet requested changes Jan 22, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Here are a few comments

@baywet
Copy link
Member

baywet commented Jan 22, 2024

Can you also rebase onto vnext please so we don't get all this merge commits in the way?

baywet
baywet reviewed Jan 22, 2024
View reviewed changes
baywet
baywet requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, a couple more recommendations

@LucGenetier
Copy link
Contributor Author

LucGenetier commented Jan 24, 2024

ok

In reply to: 1904236027

baywet
baywet requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, minor comments edits I'll commit right-away

@baywet baywet enabled auto-merge (squash) January 24, 2024 13:27
@baywet baywet merged commit 51d7b30 into microsoft:vnext Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LucGenetier @baywet @andrueastman @darrelmiller @MaggieKimani1 @irvinesunday