Skip to content

Conversation

@baywet
Copy link
Member

@baywet baywet commented Sep 14, 2023

    • enables NRT for main hidi project
    • enables all mode analysis

Copy link
Contributor

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @baywet.

There is a trimming warning that is causing the release build to fail due to dotnet/runtime#59230. I believe we should probably suppress/fix before the merge.

config.GetSection(nameof(OpenApiConvertSettings)).Bind(settings);

@baywet
Copy link
Member Author

baywet commented Sep 18, 2023

@andrueastman, thanks. I went the other way around by disabling trimming since fixing it would represent significant work until the source generators are available, and suppressing it means broken functionality.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

79.6% 79.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants