Skip to content

Creates derived reference objects for on-demand reference resolution #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 20, 2023
Merged

Creates derived reference objects for on-demand reference resolution #1290

merged 25 commits into from
Jul 20, 2023

Conversation

@irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented Jul 10, 2023

Fixes #1103

This PR:

  • Creates reference objects that can be used to delegate reference resolution on-demand. This will also help in overriding the summary and description property values of the referenceable objects.
  • Adds the relevant unit tests to validate the above.

irvinesunday added 20 commits June 7, 2023 10:53
@irvinesunday
Add reference classes
f55b018
@irvinesunday
Add serialization methods to reference classes
a458d70
@irvinesunday
Modify access modifiers
9b6e0ac
@irvinesunday
Add header reference class
ddc640c
@irvinesunday
Use Target property instead of this
ef6f270
@irvinesunday
Make Reference property readonly; add constructors to get reference v…
124bd44 
…alue
@irvinesunday
Add new constructor
d57f07c
@irvinesunday
Add reference tests
eae34a7
@irvinesunday
Add Tag reference tests
82ec1fd
@irvinesunday
Update tests, method signatures and properties
d66fbf7
@irvinesunday
Revert access modifiers
0fea87f
@irvinesunday
Update methods
3608bf6
@irvinesunday
Update tests
0bfe56a
@irvinesunday
Update tests
acfc24a
@irvinesunday
Add externalResource parameter to constructors
f36d284 
This is to help capture externally referenced resources
@irvinesunday
Add tests for external reference resolution
ef22699
@irvinesunday
Add description field
9397f17
@irvinesunday
Update teg reference serializer and tests
e5abd85
@irvinesunday
Update PublicApi
571e5eb
@irvinesunday
Merge remote-tracking branch 'origin/release/2.0.0' into is/proxy-obj…
279f4aa 
…ects
@irvinesunday irvinesunday self-assigned this Jul 10, 2023
@irvinesunday irvinesunday marked this pull request as draft July 10, 2023 12:10
@irvinesunday irvinesunday marked this pull request as ready for review July 11, 2023 06:54
baywet
baywet requested changes Jul 12, 2023
View reviewed changes
@baywet
Copy link
Member

baywet commented Jul 12, 2023

Also @irvinesunday you should have a look at the bugs reported by sonarcloud

baywet
baywet reviewed Jul 18, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

4.9% 4.9% Coverage
5.6% 5.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@irvinesunday
Copy link
Contributor Author

irvinesunday commented Jul 20, 2023

@baywet are there other suggestions you had for this PR?

@irvinesunday irvinesunday merged commit 159138c into release/2.0.0 Jul 20, 2023
@irvinesunday irvinesunday deleted the is/proxy-objects branch July 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

Assignees

@irvinesunday irvinesunday

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irvinesunday @baywet