ISSUE-1131: Added diagnostic reporting recursive concatenation of dia… #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnostic reports from referenced files to the main file's diagnostic report
elize-vdr
requested review from
MaggieKimani1,
andrueastman,
baywet,
darrelmiller,
irvinesunday,
millicentachieng,
peombwa and
zengin
as code owners
Member
|
Thank you for this submission. We will review and provide feedback. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
baywet
requested changes
May 15, 2023
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution, a couple of comments to help get this across the finish line
baywet
requested changes
May 16, 2023
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for making the changes, another couple of things I missed the first time.
baywet
reviewed
Jun 7, 2023
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes and for your patience (I was out for a while).
@MaggieKimani1 for final review and merge
baywet
approved these changes
Jun 7, 2023
MaggieKimani1
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added diagnostic reporting recursive concatenation of diagnostic reports from referenced files to the main file's diagnostic report.
Also added a unit test in
C:\Users\Elize.van.der.Riet\Work\OpenAPI\OpenAPI.NET - Fork\OpenAPI.NET\test\Microsoft.OpenApi.Readers.Tests\OpenApiReaderTests\OpenApiDiagnosticTests.cs, my apologies not sure if this is the right place for the test, please let me know if I should move it.