updates master #1210
Merged
updates master #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
baywet
commented
Apr 11, 2023
baywet
commented
- Add unit test to break copy constructors
- Remove commented code
- Adds a dictionary clone helper to help us deep clone all the values of the key value pairs in a dictionary
- Add test suite; update public API
- Use DictionaryCloneHelper
- Updates XML summary
- Use DictionaryCloneHelper cloning method for all dictionary copies
- Add test case for content media type
- Update public API
- Use DictionaryCloneHelper.Clone() method
- Clean up dictionary cloning logic
- Clean up code
- Revert "Clean up dictionary cloning logic "
- Code cleanup
- Address PR feedback
- Update src/Microsoft.OpenApi/Helpers/DictionaryCloneHelper.cs
- Add null propagation
- Push uncommitted code and clean up code
- Clean up public API surface
-
- makes Path of OpenApiUrlTreeNode Writeable
- Bump Verify.Xunit from 19.12.0 to 19.12.1
…f the key value pairs in a dictionary
This reverts commit 08acaaa.
Co-authored-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 19.12.0 to 19.12.1. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@19.12.0...19.12.1) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…-19.12.1 Bump Verify.Xunit from 19.12.0 to 19.12.1
Fix Deep copying of objects implementing the dictionary type using copy constructors
- makes Path of OpenApiUrlTreeNode Writeable
baywet
requested review from
MaggieKimani1,
darrelmiller,
irvinesunday,
millicentachieng,
peombwa and
zengin
as code owners
|
SonarCloud Quality Gate failed. |
MaggieKimani1
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.