Skip to content

Make OpenApiReferenceResolver public #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2022
Merged

Make OpenApiReferenceResolver public #1027

merged 4 commits into from
Oct 4, 2022

Conversation

@MaggieKimani1
Copy link
Contributor

Fixes #1025

baywet
baywet requested changes Oct 3, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor, the errors property, and the visit methods are missing doc comments

baywet
baywet requested changes Oct 3, 2022
View reviewed changes
@MaggieKimani1 MaggieKimani1 merged commit b1fca56 into vnext Oct 4, 2022
@MaggieKimani1 MaggieKimani1 deleted the mk/make-openapi-reference-resolver-public branch October 4, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make OpenApiReferenceResolver public

4 participants

@MaggieKimani1 @peombwa @baywet