OpenAPI.NET 1.2.0 is not backwards compatible with 1.1.x

[LeroyK]

Version 1.2.0 is not backwards compatible with 1.1.x. For example, the constructor of OpenApiString has changed from:

public OpenApiString(string value);

to

public OpenApiString(string value, bool isExplicit = false);

If another project references the old version, it cannot find the constructor since its signature has changed. It would have been better to add a new constructor or increase the major version number of the package (if you adhere to semantic versioning). At the very least, breaking api changes should be documented in the release notes.

[CumpsD]

This just bit me

System.MissingMethodException: Method not found: 'Void Microsoft.OpenApi.Any.OpenApiString..ctor(System.String)'.

[CumpsD]

Added a PR: #489

Would be nice to merge it, bump your version and unlist 1.2.0

[CumpsD]

@darrelmiller any chance for your input on this one please?

[darrelmiller]

Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility.

[CumpsD]

Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility.

Yep :) Compiler magic...

[hasancemcerit]

With 1.2.1, the previous OpenApiString error just got transformed into

Method not found: 'Void Microsoft.OpenApi.Writers.OpenApiJsonWriter..ctor(System.IO.TextWriter)'.
🤔

[CumpsD]

@hasancemcerit PR ongoing to fix it: #492

[CumpsD]

It's fixed. 1.2.2 has no breaking changes, and the others got delisted.

@darrelmiller This can probably be closed now :)

[darrelmiller]

@CumpsD Thank you for your help with this.