-
Notifications
You must be signed in to change notification settings - Fork 280
Closed
Labels
priority:p1High priority but not blocking. Causes major but not critical loss of functionality SLA <=7daysHigh priority but not blocking. Causes major but not critical loss of functionality SLA <=7daystype:bugA broken experienceA broken experience
Description
The value from the leave open setting should be passed to the StreamReaderConstructor so it doesn't dispose the stream when asked to keep it open.
Repro:
var stream = new MemoryStream();
// copy the value from a file stream, string etc.. in the stream
var settings = new OpenApiReaderSettings
{
LeaveStreamOpen = true,
};
var reader = new OpenApiStreamReader(settings);
var result = await reader.ReadAsync(input, cancellationToken)
stream.Seek(0, SeekOrigin.Begin); // results in a object disposed exception when it shouldn'tWhen this is fixed, we can clean WorskpaceManagementService.MigrateFromLockFileAsync in kiota.
andrueastman
Metadata
Metadata
Assignees
Labels
priority:p1High priority but not blocking. Causes major but not critical loss of functionality SLA <=7daysHigh priority but not blocking. Causes major but not critical loss of functionality SLA <=7daystype:bugA broken experienceA broken experience